[2024] SU2 Beta SDK 1.3.3 Blender exporter 3.3.1 - Non critical - code clean up

Version: *1.4.14.0

Frequency: Consistently

Severity: *Low - clean up
(Low - quality of life, workflow optimization, rare enough to not impact production, etc…
High - critical but workarounds are available, important feature not working as expected, frequent enough to impact production
Blocker - prevents from working on the project, prevents from releasing the product)

Marketplace package name: if applicable

Context: What package? When editing or mounted from Community? In main menu or in flight? etc…

Similar MSFS 2020 issue: insert url here if applicable

Bug description:

Duplication of nodes in msfs_material.py

        multiply_vertex_color_node = add_node(
            nodes=group.nodes,
            type_node=MSFS2024_ShaderNodeTypes.SHADERNODEMATH.value,
            operation=MSFS2024_NodeMathOpe.MULTIPLY.value,
            location=(900.0, 50.0),
            width=200.0
        )

        multiply_vertex_color_node = add_node(
            nodes=group.nodes,
            type_node=MSFS2024_ShaderNodeTypes.SHADERNODEMATH.value,
            operation=MSFS2024_NodeMathOpe.MULTIPLY.value,
            location=(900.0, 50.0),
            width=200.0
        )

        vertex_color_map_node = add_node(
            nodes=group.nodes,
            name=MSFS2024_NodesSockets.VERTEXCOLOR.value,
            type_node=MSFS2024_ShaderNodeTypes.SHADERNODEVERTEXCOLOR.value,
            location=(700, -125)
        )

        greather_than_node = add_node(
            nodes=group.nodes,
            type_node=MSFS2024_ShaderNodeTypes.SHADERNODEMATH.value,
            operation=MSFS2024_NodeMathOpe.GREATER_THAN.value,
            location=(1180.0, -165.0),
            width=200.0
        )

        greather_than_node = add_node(
            nodes=group.nodes,
            type_node=MSFS2024_ShaderNodeTypes.SHADERNODEMATH.value,
            operation=MSFS2024_NodeMathOpe.GREATER_THAN.value,
            location=(1180.0, -165.0),
            width=200.0
        )

node comments are swapped - Add comment is subtract node and visa versa

        # Sub Offset U
        add_offset_u_node = add_node(
            nodes=group.nodes,
            type_node=MSFS2024_ShaderNodeTypes.SHADERNODEMATH.value,
            operation=MSFS2024_NodeMathOpe.ADD.value,
            location=(450.0, -10.0)
        )

        # Add Offset V
        sub_offset_v_node = add_node(
            nodes=group.nodes,
            type_node=MSFS2024_ShaderNodeTypes.SHADERNODEMATH.value,
            operation=MSFS2024_NodeMathOpe.SUBTRACT.value,
            location=(450.0, -50.0)
        )

spelling in msfs_material_clearcoat.py

        ## Clearcoat Normal Tlining
        MSFS2024_MaterialUtilsUI.draw_prop(
            layout=box,
            material=material,
            prop=MSFS2024_MaterialProperties.CLEARCOATNORMALTILING.attribute_name()
        )

in material_parallax.py - node position should be updated.


        ## Behind Glass Texture
        # Out[0] : Albedo Detail Mix -> In[2]
        behind_glass_tex_node = add_node(
            nodes=self.nodes,
            name=MSFS2024_ShaderNodes.BEHINDGLASSTEX.value,
            type_node=MSFS2024_ShaderNodeTypes.SHADERNODETEXIMAGE.value,
            location=(500, 500.0),
            frame=parallax_frame
        )

        ## Albedo Detail Mix
        # In[2] :  Behind Glass Texture -> Out[0]
        albedo_detail_mix_node = add_node(
            nodes=self.nodes,
            name="Albedo Detail Mix",
            type_node=MSFS2024_ShaderNodeTypes.SHADERNODEMIXRGB.value,
            blend_type = MSFS2024_NodeBlendTypes.MIX.value,
            location=(800.0, 500.0),
            frame=parallax_frame
        )

make 500, 500 change to 500, -800

Repro steps:

Attachments:

Private attachments: Send a PM to @PrivateContent with the link to this topic and the link to download your content

Hello,

This will be fixed, thank you.

Regards,
Boris

This topic has been automatically closed after 60 days of inactivity since it was marked as fixed.

If there is important new information about this same report, you can use the “Request reopen” button below to ask the moderation team to review it again.
For other issues or broader discussion, please open a new topic in the appropriate category.