fsVfxSetWorldPosition, fsVfxSetRotation throwing exceptions

[MSFS 2024] Bug Reports WASM
, ,
1

Version: 1.6.31.0

Frequency: Consistently

Severity: Blocker

Context: in a WASM module, after injecting a particle effect at a lat/lon in the world

Bug description: The following Exception gets thrown when trying to relocate an effect

Exception thrown at 0x00007FF7D0A6B3E3 in FlightSimulator2024.exe: 0xC0000005: Access violation writing location 0x0000000000000070.

Repro steps:

  1. Inject an effect using id = fsVfxSpawnInWorld
  2. Call fsVfxSetWorldPosition(id...) or fsVfxSetRotation(id...)to relocate the effect

Follow-up question: Do you guys have test coverage for those WASM functions?

2

Hello @runshotgun ,

I tried modifying the Sample VFX Aircraft to add fsVfxSetWorldPosition and fsVfxSetRotation, and so far I haven’t been able to reproduce an exception.

Do you see any related messages in the console?

Could you send us your project, or at least a minimal sample that reproduces the issue, please?
See 3) Provide Private Content

Thank you

Regards,
Boris

3

It seems like I can’t reproduce the issue on the latest build either.
Reviewing this but consider it solved for now

1 Like
4

Ok

Thank you for the feedback

Regards,
Boris

5

Scratch that, I had the 2 lines disabled in my code. The issue is reproducible. File send in Private Content.

image
image1713×436 81.1 KB

6

Hi @runshotgun ,

I was able to reproduce the freeze using your code and logged an issue.

However :

In the code, you initialize
L.35 : FsVfxId effect_uid = -1;

Any reason not to use FSVFXID_NULL instead?
FSVFXID_NULL is 0xffffffff
I may be wrong but if fsVfxSpawnInWorld() fails and returns FSVFXID_NULL, your later check if (effect_uid > -1)will be true and you will be calling fsVfxSetWorldPosition / fsVfxSetRotation. That could explain the freeze/crash.

I think you should/could use fsVfxIsValid(effect_uid) instead.

Regards,
Boris

1 Like
7

Thanks for the heads up!
We’ll put in those changes.

1 Like